Fix recursive {this} evaluation in Natvis#1549
Merged
WardenGnaw merged 1 commit intomainfrom Mar 16, 2026
Merged
Conversation
WardenGnaw
force-pushed
the
dev/waan/recursiveThis
branch
from
dc07d1d to
ad1ae1c
Compare
This PR addresses the issue where using `this` in natvis causes it to recursively evaluate. Added a check during evaluation if the name is this, special case to just return as is instead of contuining recursing. Added tests to handle the case. Addresses #1391
WardenGnaw
force-pushed
the
dev/waan/recursiveThis
branch
from
ad1ae1c to
aaf9e66
Compare
gregg-miskelly
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue where using
thisin natvis causes it to recursively evaluate. Added a check during evaluation if the name is this, special case to just return as is instead of contuining recursing.Added tests to handle the case.
Addresses #1391